Fix DQN w RNN tutorial #3462
Open
Fix DQN w RNN tutorial #3462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3462
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit f4d1b1c with merge base 9a44439 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@vmoens ^^ |
svekars
commented
Jul 14, 2025
sekyondaMeta
added a commit
that referenced
this pull request
Jul 16, 2025
Resetting changes in favor of: #3462
vmoens
reviewed
Jul 17, 2025
| policy = Seq(feature, lstm.set_recurrent_mode(True), mlp, qval) | ||
| from torchrl.modules import set_recurrent_mode | ||
|
|
||
| with set_recurrent_mode(True): |
There was a problem hiding this comment.
This is to be set during the loss computation.
The policy module given to the collector and to the loss will be the same. The decorator is to be set to True whenever a recurrent call is required (typically within the loss).
There was a problem hiding this comment.
Can you check the update, @vmoens ?
Thanks, @vmoens. I just attempted that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3450
Fixes https://github.com/pytorch/tutorials/actions/runs/16273680500/job/45947334373?pr=3416#step:9:8137